RFR: 8338668: Test javax/swing/JFileChooser/8080628/bug8080628.java doesn't test for GTK L&F [v2]
Phil Race
prr at openjdk.org
Fri Aug 23 18:06:06 UTC 2024
On Fri, 23 Aug 2024 09:28:22 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> This test should have failed with the [changeset](https://github.com/openjdk/jdk/pull/20612) proposed for [JDK-4795384](https://bugs.openjdk.org/browse/JDK-4795384) but it didn't because GTK look and feel isn't supported in headless environment.
>>
>> Fix is to run the test with headful environment on linux platform.
>>
>> Tested in CI pipeline and link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comment update
I guess this is OK. It is a bit of an anomaly that GTK requires headful and not so easy to explain to users, but it is a lot easier to fix a test than deal with making GTK work in headless mode ..
-------------
Marked as reviewed by prr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20671#pullrequestreview-2257810893
More information about the client-libs-dev
mailing list