RFR: 8338103: Stabilize and open source a Swing OGL ButtonResizeTest [v4]

Phil Race prr at openjdk.org
Tue Aug 27 16:54:07 UTC 2024


On Tue, 27 Aug 2024 16:46:23 GMT, Phil Race <prr at openjdk.org> wrote:

>> Thanks @prrace , I have added more pipelines to the test, please have a look. I have rerun this again on all platforms with mach5 and the results are updated in the bug as a comment.
>
> Looks like it failed on Linux with the default pipeline, which should be xrender. That's a bit surprising. 
> You should verify this and if necessary file a bug and exclude that failing combination from testing.

Also, I see you added metal.
I think I'm going to request an extra layer on top of what I previously suggested.

It is possible to have multiple @test tags, not just @run tags, so you can do platform-specific things on just the specific platform, so it would become

 /* @test 
    @requires("os.name"="windows")
   @run main/othervm -Dsun.java2d.d3d=false
   @run main/othervm -Dsun.java2d.d3d=true
*/

 /* @test 
    @requires("os.name"="macos")
   @run main/othervm -Dsun.java2d.d3d=false
   @run main/othervm -Dsun.java2d.metal=true
*/


 /* @test 
    @requires("os.name"="linux")
   @run main/othervm -Dsun.java2d.xrender=false
   @run main/othervm -Dsun.java2d.xrender=true
*/

and finally the one that is cross-platform AND defaults
 /* @test 
   @run/main/othervm
   @run main/othervm -Dsun.java2d.opengl=false
   @run main/othervm -Dsun.java2d.opengl=true
*/

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20532#discussion_r1733227340


More information about the client-libs-dev mailing list