RFR: 8339309: unused-variable warnings happen in libfontmanager

Yasumasa Suenaga ysuenaga at openjdk.org
Fri Aug 30 10:23:33 UTC 2024


I saw following errors (warnings) when I tried to build OpenJDK on Fedora 40 with gcc-14.2.1-1.fc40.x86_64:


/home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/HBShaper_Panama.c: In function ‘jdk_hb_shape’:
/home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/HBShaper_Panama.c:101:16: error: unused variable ‘yPtSize’ [-Werror=unused-variable]
  101 | float yPtSize = euclidianDistance(matrix[2], matrix[3]);
      | ^~~~~~~
cc1: all warnings being treated as errors
* For target support_native_java.desktop_libfontmanager_X11FontScaler.o:
/home/ysuenaga/github-forked/jdk/src/java.desktop/unix/native/libfontmanager/X11FontScaler.c: In function ‘Java_sun_font_NativeFont_getGlyphAdvance’:
/home/ysuenaga/github-forked/jdk/src/java.desktop/unix/native/libfontmanager/X11FontScaler.c:270:32: error: unused variable ‘descent’ [-Werror=unused-variable]
  270 | int direction, ascent, descent;
      | ^~~~~~~
/home/ysuenaga/github-forked/jdk/src/java.desktop/unix/native/libfontmanager/X11FontScaler.c:270:24: error: unused variable ‘ascent’ [-Werror=unused-variable]
  270 | int direction, ascent, descent;
      | ^~~~~~
/home/ysuenaga/github-forked/jdk/src/java.desktop/unix/native/libfontmanager/X11FontScaler.c:270:13: error: unused variable ‘direction’ [-Werror=unused-variable]
  270 | int direction, ascent, descent;
      | ^~~~~~~~~
/home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c: In function ‘Java_sun_font_FreetypeFontScaler_createScalerContextNative’:
/home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c:516:19: error: unused variable ‘scalerInfo’ [-Werror=unused-variable]
  516 | FTScalerInfo *scalerInfo =
      | ^~~~~~~~~~
/home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c: In function ‘Java_sun_font_FreetypeFontScaler_getGlyphPointNative’:
/home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libfontmanager/freetypeScaler.c:1655:13: error: unused variable ‘point’ [-Werror=unused-variable]
 1655 | jobject point = NULL;
      | ^~~~~

-------------

Commit messages:
 - 8339309: unused-variable warnings happen in libfontmanager

Changes: https://git.openjdk.org/jdk/pull/20790/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20790&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339309
  Stats: 8 lines in 3 files changed: 0 ins; 5 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/20790.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20790/head:pull/20790

PR: https://git.openjdk.org/jdk/pull/20790


More information about the client-libs-dev mailing list