RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v4]
ScientificWare
duke at openjdk.org
Sun Dec 1 00:50:12 UTC 2024
> This is referenced in Java Bug Database as
> - [JDK-8314731 : Adds support for the alt attribute in the image type input HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731)
>
> This is tracked in JBS as
> - [JDK-8314731 : Add support for the alt attribute in the image type input HTML tag](https://bugs.openjdk.java.net/browse/JDK-8314731)
>
> According [HTML 3.2 specification](https://www.w3.org/TR/2018/SPSD-html32-20180315/#input)
>
> `alt` is not an attribute of the `input` element.
>
> According [HTML 4.01 specifications](https://www.w3.org/TR/html4/interact/forms.html#h-17.4) :
>
>> ... For accessibility reasons, authors should provide [alternate text](https://www.w3.org/TR/html4/struct/objects.html#alternate-text) for the image via the [alt](https://www.w3.org/TR/html4/struct/objects.html#adef-alt) attribute. ...
>
> This feature is not implemented in `FormView.java`.
>
> ⚠️ ~~This also affects the HTML 32 DTD~~
>
> 
>
> Left before the patch and right after the patch.
>
>
> import java.awt.BorderLayout;
> import java.awt.Dimension;
> import javax.swing.JEditorPane;
> import javax.swing.JFrame;
> import javax.swing.JScrollPane;
> import javax.swing.SwingUtilities;
> import javax.swing.text.Document;
> import javax.swing.text.html.HTMLEditorKit;
> import javax.swing.text.html.StyleSheet;
>
> public class HTMLAddsSupportAltInputTag {
> public static void main(String[] args) {
> new HTMLAddsSupportAltInputTag();
> }
>
> public HTMLAddsSupportAltInputTag() {
> SwingUtilities.invokeLater(new Runnable(){
> public void run(){
> JEditorPane jEditorPane = new JEditorPane();
> jEditorPane.setEditable(false);
> JScrollPane scrollPane = new JScrollPane(jEditorPane);
> HTMLEditorKit kit = new HTMLEditorKit();
> jEditorPane.setEditorKit(kit);
> StyleSheet styleSheet = kit.getStyleSheet();
> styleSheet.addRule("""
> body {
> color: #000;
> font-family:times;
> margin: 4px;
> }
> """);
> String htmlString = """
> <html>
> <body>
> <input type=image name=point src="file:oracle_logo_50x50.jpg" alt="Logo Oracle JPG">
> <p>
> <input type=image name=point src="file:none_oracle_logo_50x50.jpg" alt="Logo Oracle JPG">
> <p>
> <input type=image name=point src...
ScientificWare has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
- Adds a regression test for JDK-8314731.
- Others changes in the working directory.
- Merge Master
- Merge master
- FormView.java :
- Pass altAtt as the description parameter in the ImageIcon constructor.
- Merge branch 'scientificware-patch-006-HTML-adds_input_tag_image_type_alt_attribute_support' of github.com:scientificware/jdk into scientificware-patch-006-HTML-adds_input_tag_image_type_alt_attribute_support
- Update src/java.desktop/share/classes/javax/swing/text/html/FormView.java
FormView.java : Remove a redundant space.
Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
- Merge master
- Merge master
- Merge master
- ... and 4 more: https://git.openjdk.org/jdk/compare/28ae281b...242bf546
-------------
Changes: https://git.openjdk.org/jdk/pull/15319/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15319&range=03
Stats: 235 lines in 5 files changed: 230 ins; 1 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/15319.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15319/head:pull/15319
PR: https://git.openjdk.org/jdk/pull/15319
More information about the client-libs-dev
mailing list