RFR: 8343736: Test java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java failed: Choice can't be controlled by keyboard [v2]

Damon Nguyen dnguyen at openjdk.org
Mon Dec 2 17:42:22 UTC 2024


On Fri, 29 Nov 2024 05:15:24 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - String comparison
>>  - Review comments
>
> test/jdk/java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java line 110:
> 
>> 108:             loc = button.getLocationOnScreen();
>> 109:         });
>> 110:         robot.mouseMove(loc.x + button.getWidth() / 2, loc.y
> 
> get button's width and height on EDT along with location.

Done

> test/jdk/java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java line 116:
> 
>> 114:         robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
>> 115:         robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
>> 116:         System.out.println("EIGHT");
> 
> Any reason to add these many print statements ? Is it for debugging purpose?

Yes, was trying to test failure points again. Removed now!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22333#discussion_r1866309901
PR Review Comment: https://git.openjdk.org/jdk/pull/22333#discussion_r1866309559


More information about the client-libs-dev mailing list