RFR: JDK-8344368 : IndependenceSwingTest.java and IndependenceAWTTest.java failed: Selected text & clipboard contents differs [v2]
Harshitha Onkar
honkar at openjdk.org
Mon Dec 2 19:12:38 UTC 2024
On Mon, 2 Dec 2024 19:03:55 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> The following two tests failed intermittently due to stability issues after JEP486 (Removal of Security Manager). Tests have been updated for stability.
>> This test is applicable for linux platform only, hence `@requires (os.family == "linux")` jtreg tag is added and the redundant OS check within the test is removed.
>>
>> - java/awt/datatransfer/Independence/IndependenceAWTTest.java
>> - java/awt/datatransfer/Independence/IndependenceSwingTest.java
>>
>> Multiple runs of the test on CI looks good and the tests pass.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> removed redundant null check
test/jdk/java/awt/datatransfer/Independence/IndependenceAWTTest.java line 128:
> 126:
> 127: tp = primaryClip.getContents(null);
> 128: ts = systemClip.getContents(null);
Not related to stabilization but I noticed that requestor param is no longer used in Clipboard's [getContents()](https://github.com/openjdk/jdk/blob/7c944ee6f4dda4f1626721d63ac6bc6d1b40d33b/src/java.datatransfer/share/classes/java/awt/datatransfer/Clipboard.java#L146), hence it was changed to null.
`primaryClip.getContents(null)`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22490#discussion_r1866463894
More information about the client-libs-dev
mailing list