RFR: 8345141: Remove uses of SecurityManager in ShellFolder related classes [v2]
Harshitha Onkar
honkar at openjdk.org
Mon Dec 2 22:43:37 UTC 2024
On Sat, 30 Nov 2024 03:50:24 GMT, Phil Race <prr at openjdk.org> wrote:
>> Remove SecurityManager related code from Swing filechooser implementation
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>
> 8345141
LGTM, apart from the unused import in ShellFolderManager after checkFiles removal.
src/java.desktop/share/classes/sun/awt/shell/ShellFolderManager.java line 122:
> 120: }
> 121:
> 122: private static File[] checkFiles(Stream<File> fs, @SuppressWarnings("removal") SecurityManager sm) {
Minor: Similar to what @azvegint pointed out in Win32ShellFolderManager.java `import java.util.stream.Stream;` is unused after removal of this method.
-------------
Marked as reviewed by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22423#pullrequestreview-2474093435
PR Review Comment: https://git.openjdk.org/jdk/pull/22423#discussion_r1866724149
More information about the client-libs-dev
mailing list