RFR: 8345398: Avoid redundant Properties.containsKey call in Cursor.getSystemCustomCursor

Andrey Turbanov aturbanov at openjdk.org
Tue Dec 3 18:05:47 UTC 2024


On Tue, 3 Dec 2024 15:52:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> `Properties` doesn't allow `null` values.
>> We can replace containsKey+getProperty with getProperty+null check.
>> It's clearer and a bit faster.
>
> src/java.desktop/share/classes/java/awt/Cursor.java line 303:
> 
>> 301:             String key    = prefix + DOT_FILE_SUFFIX;
>> 302: 
>> 303:             String fileName = systemCustomCursorProperties.getProperty(key);
> 
> You can keep the `final` modifier, probably.

I really like how this line now fits in 80 characters limit. But if you insist - I will return it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21824#discussion_r1868181704


More information about the client-libs-dev mailing list