RFR: 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04 [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Wed Dec 4 13:47:24 UTC 2024
On Wed, 4 Dec 2024 13:17:14 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review
>
> test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java line 59:
>
>> 57: robot.delay(200);
>> 58:
>> 59: int value = getValue();
>
> `getValue()` can be evaluated in if condition directly, no need to have `value` variable.
>
> typo in incorrect
> throw new Error("The scrollbar block increment is `incorrect`");
>
> may be changed to RTE instead of Error.
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22540#discussion_r1869530570
More information about the client-libs-dev
mailing list