RFR: 8345447: test/jdk/javax/swing/JToolBar/4529206/bug4529206.java fails in ubuntu22.04 [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Wed Dec 4 13:53:12 UTC 2024
On Wed, 4 Dec 2024 13:33:56 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review
>
> test/jdk/javax/swing/JToolBar/4529206/bug4529206.java line 1:
>
>> 1: /*
>
> Since you are modifying this test, couple of suggestions:
>
> 1. Please limit L67 to 80 cols.
> 2. I guess L91 and L92 can be merged, it's slightly over 80 cols but should be ok. If not then may be split like
> throw new RuntimeException("setFloating" +
> "does not work correctly");
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22536#discussion_r1869553180
More information about the client-libs-dev
mailing list