RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v8]

ScientificWare duke at openjdk.org
Sun Dec 8 19:47:42 UTC 2024 

On Tue, 3 Dec 2024 22:09:57 GMT, Phil Race <prr at openjdk.org> wrote:

>> ScientificWare has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits:
>> 
>>  - Merge master
>>  - Replaces this title with "alt attribute test in HTML image type input".
>>    
>>    Moves this test to /jdk/test/jdk/javax/swing/text/html.
>>  - bug8314731.java : Corrects the CopyRight date.
>>  - FormView.java :
>>    Removes a whitespace
>>    
>>    bug8314731.java :
>>    Adds a newline at end of file.
>>  - getMaximumSpan(int axis) method
>>    doc -> Not used
>>    
>>    mouseReleased(MouseEvent evt) method
>>    elem and hdoc -> not used
>>    return -> could be removed, method returns void
>>    
>>    loadElementDataIntoBuffer(Element elem, StringBuilder buffer) method
>>    value != null -> name can't be null at this point
>>    
>>    getInputElementData(AttributeSet attr) method
>>    value = null -> Already set at null
>>  - Removes files
>>    
>>    make/javac.20231014_162919.args
>>    make/javac.20231014_220237.args
>>    make/javac.20231023_221655.args
>>  - Adds a regression test for JDK-8314731.
>>  - Others changes in the working directory.
>>  - Merge Master
>>  - Merge master
>>  - ... and 10 more: https://git.openjdk.org/jdk/compare/352201dd...de644539
>
> test/jdk/javax/swing/text/html/bug8314731.java line 51:
> 
>> 49: 
>> 50:     public static void main(String[] args) throws Exception {
>> 51:         new bug8314731();
> 
> the UI needs to be created on the EDT using SwingUtilities.invokeAndWait.
> And you need use a finally block to be SURE the Frame is disposed, else the test will just sit there.
> 
> Please make sure you have used jtreg to validate this test.

Test Passed with JDK master patched
<details>


----------System.out:(1/3)----------
ok
----------System.err:(1/15)----------
STATUS:Passed.
----------rerun:(40/2653)*----------
cd /home/scientificwaredev/Documents/openjdk-sources/JTwork/scratch && \\
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus \\
DESKTOP_SESSION=01plasma \\
DISPLAY=:0 \\
HOME=/home/scientificwaredev \\
LANG=fr_FR.UTF-8 \\
PATH=/bin:/usr/bin:/usr/sbin \\
XDG_CONFIG_DIRS=/home/scientificwaredev/.config/kdedefaults:/etc/xdg:/etc/xdg/kf5:/var/lib/plasma5-profiles/common/xdg \\
XDG_CURRENT_DESKTOP=KDE \\
XDG_DATA_DIRS=/home/scientificwaredev/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share:/usr/share \\
XDG_MENU_PREFIX=plasma- \\
XDG_RUNTIME_DIR=/run/user/1000 \\
XDG_SEAT=seat0 \\
XDG_SEAT_PATH=/org/freedesktop/DisplayManager/Seat0 \\
XDG_SESSION_CLASS=user \\
XDG_SESSION_DESKTOP=KDE \\
XDG_SESSION_ID=c2 \\
XDG_SESSION_PATH=/org/freedesktop/DisplayManager/Session1 \\
XDG_SESSION_TYPE=x11 \\
XDG_VTNR=2 \\
XMODIFIERS=@im=none \\
CLASSPATH=/home/scientificwaredev/Documents/openjdk-sources/JTwork/classes/javax/swing/text/html/bug8314731.d:/home/scientificwaredev/Documents/openjdk-sources/jdk/test/jdk/javax/swing/text/html:/home/scientificwaredev/Documents/jtreg/lib/javatest.jar:/home/scientificwaredev/Documents/jtreg/lib/jtreg.jar \\
    /home/scientificwaredev/Documents/openjdk-sources/jdk/build/linux-x86_64-server-release/jdk/bin/java \\
        -Dtest.vm.opts= \\
        -Dtest.tool.vm.opts= \\
        -Dtest.compiler.opts= \\
        -Dtest.java.opts= \\
        -Dtest.jdk=/home/scientificwaredev/Documents/openjdk-sources/jdk/build/linux-x86_64-server-release/jdk \\
        -Dcompile.jdk=/home/scientificwaredev/Documents/openjdk-sources/jdk/build/linux-x86_64-server-release/jdk \\
        -Dtest.timeout.factor=1.0 \\
        -Dtest.root=/home/scientificwaredev/Documents/openjdk-sources/jdk/test/jdk \\
        -Dtest.name=javax/swing/text/html/bug8314731.java \\
        -Dtest.file=/home/scientificwaredev/Documents/openjdk-sources/jdk/test/jdk/javax/swing/text/html/bug8314731.java \\
        -Dtest.src=/home/scientificwaredev/Documents/openjdk-sources/jdk/test/jdk/javax/swing/text/html \\
        -Dtest.src.path=/home/scientificwaredev/Documents/openjdk-sources/jdk/test/jdk/javax/swing/text/html \\
        -Dtest.classes=/home/scientificwaredev/Documents/openjdk-sources/JTwork/classes/javax/swing/text/html/bug8314731.d \\
        -Dtest.class.path=/home/scientificwaredev/Documents/openjdk-sources/JTwork/classes/javax/swing/text/html/bug8314731.d \\
        -Dtest.modules=java.desktop \\
        --add-modules java.desktop \\
        com.sun.javatest.regtest.agent.MainWrapper /home/scientificwaredev/Documents/openjdk-sources/JTwork/javax/swing/text/html/bug8314731.d/main.0.jta
result: Passed. Execution successful


test result: Passed. Execution successful


</details>

Test Failed with JDK 23.0.1.
<details>


----------System.out:(0/0)----------
----------System.err:(11/728)----------
java.lang.RuntimeException: FormView doesn't support the alt attribute, see JDK-8314731.
	at bug8314731.main(bug8314731.java:57)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
	at java.base/java.lang.Thread.run(Thread.java:1575)

JavaTest Message: Test threw exception: java.lang.RuntimeException: FormView doesn't support the alt attribute, see JDK-8314731.
JavaTest Message: shutting down test

STATUS:Failed.`main' threw exception: java.lang.RuntimeException: FormView doesn't support the alt attribute, see JDK-8314731.
----------rerun:(40/2512)*----------
cd /home/scientificwaredev/Documents/openjdk-sources/JTwork/scratch && \\
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus \\
DESKTOP_SESSION=01plasma \\
DISPLAY=:0 \\
HOME=/home/scientificwaredev \\
LANG=fr_FR.UTF-8 \\
PATH=/bin:/usr/bin:/usr/sbin \\
XDG_CONFIG_DIRS=/home/scientificwaredev/.config/kdedefaults:/etc/xdg:/etc/xdg/kf5:/var/lib/plasma5-profiles/common/xdg \\
XDG_CURRENT_DESKTOP=KDE \\
XDG_DATA_DIRS=/home/scientificwaredev/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share:/usr/share \\
XDG_MENU_PREFIX=plasma- \\
XDG_RUNTIME_DIR=/run/user/1000 \\
XDG_SEAT=seat0 \\
XDG_SEAT_PATH=/org/freedesktop/DisplayManager/Seat0 \\
XDG_SESSION_CLASS=user \\
XDG_SESSION_DESKTOP=KDE \\
XDG_SESSION_ID=c2 \\
XDG_SESSION_PATH=/org/freedesktop/DisplayManager/Session1 \\
XDG_SESSION_TYPE=x11 \\
XDG_VTNR=2 \\
XMODIFIERS=@im=none \\
CLASSPATH=/home/scientificwaredev/Documents/openjdk-sources/JTwork/classes/javax/swing/text/html/bug8314731.d:/home/scientificwaredev/Documents/openjdk-sources/jdk/test/jdk/javax/swing/text/html:/home/scientificwaredev/Documents/jtreg/lib/javatest.jar:/home/scientificwaredev/Documents/jtreg/lib/jtreg.jar \\
    /home/scientificwaredev/Documents/jdk-23.0.1/bin/java \\
        -Dtest.vm.opts= \\
        -Dtest.tool.vm.opts= \\
        -Dtest.compiler.opts= \\
        -Dtest.java.opts= \\
        -Dtest.jdk=/home/scientificwaredev/Documents/jdk-23.0.1 \\
        -Dcompile.jdk=/home/scientificwaredev/Documents/jdk-23.0.1 \\
        -Dtest.timeout.factor=1.0 \\
        -Dtest.root=/home/scientificwaredev/Documents/openjdk-sources/jdk/test/jdk \\
        -Dtest.name=javax/swing/text/html/bug8314731.java \\
        -Dtest.file=/home/scientificwaredev/Documents/openjdk-sources/jdk/test/jdk/javax/swing/text/html/bug8314731.java \\
        -Dtest.src=/home/scientificwaredev/Documents/openjdk-sources/jdk/test/jdk/javax/swing/text/html \\
        -Dtest.src.path=/home/scientificwaredev/Documents/openjdk-sources/jdk/test/jdk/javax/swing/text/html \\
        -Dtest.classes=/home/scientificwaredev/Documents/openjdk-sources/JTwork/classes/javax/swing/text/html/bug8314731.d \\
        -Dtest.class.path=/home/scientificwaredev/Documents/openjdk-sources/JTwork/classes/javax/swing/text/html/bug8314731.d \\
        -Dtest.modules=java.desktop \\
        --add-modules java.desktop \\
        com.sun.javatest.regtest.agent.MainWrapper /home/scientificwaredev/Documents/openjdk-sources/JTwork/javax/swing/text/html/bug8314731.d/main.0.jta
result: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: FormView doesn't support the alt attribute, see JDK-8314731.


test result: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: FormView doesn't support the alt attribute, see JDK-8314731.


</details>

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15319#discussion_r1875026909

More information about the client-libs-dev mailing list