RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v9]

Sun Dec 8 19:59:23 UTC 2024

> This is referenced in Java Bug Database as
> - [JDK-8314731 : Adds support for the alt attribute in the image type input HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731)
> 
> This is tracked in JBS as
> - [JDK-8314731 : Add support for the alt attribute in the image type input HTML tag](https://bugs.openjdk.java.net/browse/JDK-8314731)
> 
> According [HTML 3.2 specification](https://www.w3.org/TR/2018/SPSD-html32-20180315/#input)
> 
> `alt` is not an attribute of the `input` element.
> 
> According [HTML 4.01 specifications](https://www.w3.org/TR/html4/interact/forms.html#h-17.4) : 
> 
>> ... For accessibility reasons, authors should provide [alternate text](https://www.w3.org/TR/html4/struct/objects.html#alternate-text) for the image via the [alt](https://www.w3.org/TR/html4/struct/objects.html#adef-alt) attribute. ...
> 
> This feature is not implemented in `FormView.java`.
> 
> ⚠️  ~~This also affects the HTML 32 DTD~~
> 
> ![Screenshot_20230817_025316](https://github.com/openjdk/jdk/assets/19194678/8e580574-d842-4a65-884b-26e33cd12138)
> 
> Left before the patch and right after the patch.
> 
> 
> import java.awt.BorderLayout;
> import java.awt.Dimension;
> import javax.swing.JEditorPane;
> import javax.swing.JFrame;
> import javax.swing.JScrollPane;
> import javax.swing.SwingUtilities;
> import javax.swing.text.Document;
> import javax.swing.text.html.HTMLEditorKit;
> import javax.swing.text.html.StyleSheet;
> 
> public class HTMLAddsSupportAltInputTag {
>   public static void main(String[] args) {
>     new HTMLAddsSupportAltInputTag();
>   }
>   
>   public HTMLAddsSupportAltInputTag() {
>     SwingUtilities.invokeLater(new Runnable(){
>       public void run(){
>         JEditorPane jEditorPane = new JEditorPane();
>         jEditorPane.setEditable(false);
>         JScrollPane scrollPane = new JScrollPane(jEditorPane);
>         HTMLEditorKit kit = new HTMLEditorKit();
>         jEditorPane.setEditorKit(kit);
>         StyleSheet styleSheet = kit.getStyleSheet();
>         styleSheet.addRule("""
>             body {
>                 color: #000;
>                 font-family:times;
>                 margin: 4px;
>             }
>             """);
>         String htmlString = """
>             <html>
>                 <body>
>                     <input type=image name=point src="file:oracle_logo_50x50.jpg" alt="Logo Oracle JPG">
>                     <p>
>                     <input type=image name=point src="file:none_oracle_logo_50x50.jpg" alt="Logo Oracle JPG">
>                     <p>
>                     <input type=image name=point src...

ScientificWare has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 23 commits:

 - Merge master
 - Merge master
 - jdk-8314731 : FormView Alt Support.

   FormView.java :
   - revert ALL unrelated changing to formatting.

   bug8314731.java :
   - Fix the test description.
   - Change where the user interface is created.
   - Add a finall block to be sure the Frame is disposed.
   - Replace "testPassed" with "testFailed".
 - Merge master
 - Replaces this title with "alt attribute test in HTML image type input".

   Moves this test to /jdk/test/jdk/javax/swing/text/html.
 - bug8314731.java : Corrects the CopyRight date.
 - FormView.java :
   Removes a whitespace

   bug8314731.java :
   Adds a newline at end of file.
 - getMaximumSpan(int axis) method
   doc -> Not used

   mouseReleased(MouseEvent evt) method
   elem and hdoc -> not used
   return -> could be removed, method returns void

   loadElementDataIntoBuffer(Element elem, StringBuilder buffer) method
   value != null -> name can't be null at this point

   getInputElementData(AttributeSet attr) method
   value = null -> Already set at null
 - Removes files

   make/javac.20231014_162919.args
   make/javac.20231014_220237.args
   make/javac.20231023_221655.args
 - Adds a regression test for JDK-8314731.
 - ... and 13 more: https://git.openjdk.org/jdk/compare/c517ffba...7464eee4

-------------

Changes: https://git.openjdk.org/jdk/pull/15319/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15319&range=08
  Stats: 183 lines in 2 files changed: 133 ins; 1 del; 49 mod
  Patch: https://git.openjdk.org/jdk/pull/15319.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15319/head:pull/15319

PR: https://git.openjdk.org/jdk/pull/15319