RFR: 8344637: Fix Page8 of manual test java/awt/print/PrinterJob/PrintTextTest.java on Linux and Windows [v7]
Daniel Gredler
dgredler at openjdk.org
Tue Dec 10 20:15:44 UTC 2024
On Wed, 20 Nov 2024 19:07:28 GMT, Daniel Gredler <dgredler at openjdk.org> wrote:
>> This PR fixes the issue identified in JDK-8148334 in screenshots `Page8_landscape.JPG` and `Page8_portrait.JPG`.
>>
>> It does not address `mac_Page1.png` or `mac_Page8.png`, which I'm not even sure are still issues (I have no access to a Mac).
>>
>> The method in question, `PathGraphics.printedSimpleGlyphVector(...)` is quite complex, with many special cases being handled in different ways. In this specific scenario (page 8 of `PrintTextTest`), all special case checks fail, and we fall through all the way to the final handling block, which draws the individual characters one by one. It looks like the problem is that the font transform translation is applied twice, once via the glyph positions, and again by `drawString(...)` via the font. The proposed fix is to provide `drawString(...)` a font without any translation transform.
>>
>> Testing looks good on Linux, but needs to be done on Mac and Windows.
>
> Daniel Gredler has updated the pull request incrementally with one additional commit since the last revision:
>
> Add additional issue ID to PrintTextTest bug list
@prrace Might you have time to review this PR in the next week or two, now that the SecurityManager exorcism is complete? The code being changed is related to a few bug fixes that you implemented over the past few years, so I'm not sure if anybody else really has as much context on this one as you do. Thanks!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21980#issuecomment-2532770362
More information about the client-libs-dev
mailing list