RFR: 8346234: javax/swing/text/DefaultEditorKit/4278839/bug4278839.java still fails in CI [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Dec 17 02:48:11 UTC 2024


On Mon, 16 Dec 2024 19:19:29 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   log caret position
>
> test/jdk/javax/swing/text/DefaultEditorKit/4278839/bug4278839.java line 71:
> 
>> 69: 
>> 70:             passed &= moveCaret(true) == 1;
>> 71:             System.out.println("passed1 moveCaret1 " + passed);
> 
> If you are trying to get more information here why not logging the actual position of the caret after the move? Either inside the moveCaret() method or just add a new variable like
> `int caret;`
> And then every time you do the test you assign it.
> `passed &= (caret = moveCaret(true)) == 1;`
> and then you can just output the new caret position after each iteration like "Expected position 1 actual position " + caret.

good point..logged..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22768#discussion_r1887822094


More information about the client-libs-dev mailing list