RFR: 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI [v2]
Abhishek Kumar
abhiscxk at openjdk.org
Wed Dec 18 06:41:36 UTC 2024
On Wed, 18 Dec 2024 03:05:16 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> javax/swing/JScrollBar/4865918/bug4865918.java fails in CI citing
>>
>> java.lang.RuntimeException: The scrollbar block increment is incorrect
>> at bug4865918.main(bug4865918.java:60)
>>
>> Seems like scrollbar is not in focus when mouse is pressed..Used CountDownLatch to mage focus gain more determinisitic.
>> Fix is passing in CI in several CI systems
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Latch update
Seems good.
test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java line 37:
> 35: import javax.swing.JScrollBar;
> 36: import javax.swing.SwingUtilities;
> 37: import java.awt.event.MouseAdapter;
awt imports can be grouped together.
-------------
PR Review: https://git.openjdk.org/jdk/pull/22783#pullrequestreview-2510920174
PR Review Comment: https://git.openjdk.org/jdk/pull/22783#discussion_r1889688526
More information about the client-libs-dev
mailing list