RFR: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17
SendaoYan
syan at openjdk.org
Wed Dec 18 09:24:40 UTC 2024
On Tue, 17 Dec 2024 15:27:30 GMT, Phil Race <prr at openjdk.org> wrote:
>> Sorry for the confuse. I mean this PR change nothing except it will print a message to stderr when realpath return NULL. Thanks magicus.
>
> Why did you integrate this ?
> It did not yet have my approval even though I was clearly reviewing it.
> Nor did it have the required 2nd reviewer, in fact did it not have ANY reviewer from the client team which is responsible for this code.
Hi @prrace , sorry for the rash integrated. I can backout this change quickly if it's necessary.
I will pay more attention for the future PRs.
Apologize for the rash integrated again.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22701#discussion_r1889897333
More information about the client-libs-dev
mailing list