RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close [v2]

[Alisen Chung]

On Tue, 30 Jan 2024 06:30:00 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Suggestions integrated

test/jdk/java/awt/print/PageFormat/PageSetupDialog.java line 225:

> 223:         }
> 224:         g2d.drawRect(1, 1, (int) pageFormat.getImageableWidth() - 2,
> 225:                 (int) pageFormat.getImageableHeight() - 2);

dispose g2D object

test/jdk/java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java line 126:

> 124:         g2d.setColor(Color.black);
> 125: 
> 126:         g2d.drawString(("This is page" + (pidx + 1)), 60, 80);

dispose g2D object

test/jdk/java/awt/print/PrinterJob/raster/RasterTest.java line 122:

> 120:             Graphics2D g2d = (Graphics2D) g;
> 121:             g2d.translate(pgFmt.getImageableX(), pgFmt.getImageableY());
> 122:             doPaint(g2d);

dispose g2D object

test/jdk/java/awt/print/PrinterJob/raster/RasterTest.java line 156:

> 154:                     new GradientPaint(10.0f, 10.0f, alphablue, 210.0f, 210.0f, alphared, true);
> 155:             g2.setPaint(gp);
> 156:             g2.fillRect(10, 240, 200, 200);

dispose g2D object (and graphics object)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1473656379
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1473656454
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1473656547
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1473657010