RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v2]

[Alisen Chung]

On Tue, 30 Jan 2024 09:17:46 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Capitalized static final variables

test/jdk/java/awt/print/PrinterJob/PrintCompoundString.java line 116:

> 114: 
> 115:             Graphics2D g2d = (Graphics2D) g;
> 116:             g2d.translate(pgFmt.getImageableX(), pgFmt.getImageableY());

dispose g2D object

test/jdk/java/awt/print/PrinterJob/PrintCompoundString.java line 127:

> 125: 
> 126:             String str = "Test string compound printing \u2203\u2200\u2211";
> 127:             g.drawString(str, 20, 40);

dispose g2D object

test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 126:

> 124: 
> 125:             Graphics2D g2d = (Graphics2D) g;
> 126:             g2d.translate(pgFmt.getImageableX(), pgFmt.getImageableY());

dispose g2D object

test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 211:

> 209:                         20, 180);
> 210:             } catch (IllegalArgumentException e) {
> 211:                 g.drawString("caught expected IAE for empty iterator, float",

dispose g2D object

test/jdk/java/awt/print/PrinterJob/PrintParenString.java line 117:

> 115: 
> 116:             Graphics2D g2d = (Graphics2D) g;
> 117:             g2d.translate(pgFmt.getImageableX(), pgFmt.getImageableY());

dispose g2D object

test/jdk/java/awt/print/PrinterJob/PrintParenString.java line 128:

> 126: 
> 127:             String str = "String containing unclosed parenthesis (.";
> 128:             g.drawString(str, 20, 40);

dispose g2D object

test/jdk/java/awt/print/PrinterJob/PrintTranslatedFont.java line 121:

> 119: 
> 120:             Graphics2D g2d = (Graphics2D) g;
> 121:             g2d.translate(pgFmt.getImageableX(), pgFmt.getImageableY());

dispose g2D object

test/jdk/java/awt/print/PrinterJob/PrintTranslatedFont.java line 150:

> 148:             sw = fm.stringWidth(str);
> 149:             g.drawString(str, posx, posy);
> 150:             g.drawLine(posx + tx, posy + ty + 2, posx + tx + sw, posy + ty + 2);

dispose g2D object

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1473657269
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1473657360
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1473657522
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1473657760
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1473658107
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1473658232
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1473658305
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1473658368