RFR: 6507038: Memory Leak in JTree / BasicTreeUI [v6]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Feb 1 03:10:21 UTC 2024


On Wed, 31 Jan 2024 17:27:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTreeUI.java line 3284:
>> 
>>> 3282:                 if(tree != null) {
>>> 3283:                     rendererPane.removeAll();
>>> 3284:                     // Only ever removed when UI changes, this is OK!
>> 
>> The comment no longer applies—you remove all the components from `rendererPane` on the line above.
>
> This is the only important thing that prevents me from approving this PR. The comment is misleading now.

OK, modified

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17458#discussion_r1473741414


More information about the client-libs-dev mailing list