RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v9]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Thu Feb 1 08:45:05 UTC 2024
On Thu, 1 Feb 2024 06:48:15 GMT, vtstydev <duke at openjdk.org> wrote:
>> More correct way to take in consideration nonzero PHYSICALOFFSETX, PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows platform under certain conditions real device prints shifted image on paper.
>
> vtstydev has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove trailing workspaces
test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java line 54:
> 52: * @build jtreg.SkippedException
> 53: * @summary Test for comparing offsets of images drawn with opaque and translucent colors printed in all orientations
> 54: * @run main/manual AlphaPrintingOffsets testAlpha
BTW, I think better will be to not pass in argument by default to make it consistent with other tests so testAlpha portion will be tested by default and if tester want to test opaque case, then he can pass in testOpaque argument
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17030#discussion_r1474023403
More information about the client-libs-dev
mailing list