RFR: 8324539: Do not use LFS64 symbols in JDK libs [v4]

Magnus Ihse Bursie ihse at openjdk.org
Fri Feb 2 06:55:19 UTC 2024


On Thu, 1 Feb 2024 15:54:40 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>>> @MBaesken So my fix in [25c691d](https://github.com/openjdk/jdk/pull/17538/commits/25c691df823eb9d9db1451637f28d59dd9508386) did not help? Maybe then it is some other system library that drags in `fcntl.h`; I assumed it was stdlib or stdio. That header file includes way too much that it does not need, so we can surely strip it of even more standard includes if that is what is required to fix this.
>> 
>> 
>> Unfortunately it did not help.
>
>> @MBaesken How annoying. :( I have now tried to remove _all_ system includes from `debug_util.h`. Can you please try again building debug on AIX, to see if it works without the `#undef` in `BufferedRenderPipe.c`?
> 
> The AIX (fast)debug  build still fails .

@MBaesken Ok, I officially give up. :-( I added your patch from https://github.com/openjdk/jdk/pull/17538#issuecomment-1918699480. I agree that it is not elegant, but at least it works.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17538#issuecomment-1923062901


More information about the client-libs-dev mailing list