RFR: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" throws and exception on Mac OS 14(x64, aarch64) [v10]

Sergey Bylokhov serb at openjdk.org
Tue Feb 6 01:10:03 UTC 2024


On Thu, 1 Feb 2024 20:52:14 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but the TrayIcon was already removed by the test, causing an error. The fix is to make SunToolkit skip posting the event if appContext is null. The test is also updated to remove applet usage and use PassFailJFrame instead.
>
> Alisen Chung has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - remove change in SunToolkit
>  - correct null change

src/java.desktop/macosx/classes/sun/lwawt/macosx/CTrayIcon.java line 176:

> 174: 
> 175:         LWCToolkit.targetDisposedPeer(target, this);
> 176:         target = null;

to make sure it is not changed in some other place you can merk the target field as final.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17329#discussion_r1479107367


More information about the client-libs-dev mailing list