RFR: 8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java
Alexey Ivanov
aivanov at openjdk.org
Tue Feb 6 16:54:55 UTC 2024
On Tue, 6 Feb 2024 11:34:28 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> The ClipShapeTest test is split into 4 different tests which could be executed in parallel.
>>
>> The execution time is changed from:
>>
>>
>> ==============================
>> Test summary
>> ==============================
>> TEST TOTAL PASS FAIL ERROR
>> jtreg:test/jdk/sun/java2d/marlin/ClipShapeTest.java
>> 1 1 0 0
>> ==============================
>> TEST SUCCESS
>>
>> Finished building target 'run-test' in configuration 'macosx-aarch64-server-release'
>>
>> real 2m58.673s
>> user 3m8.847s
>> sys 0m11.845s
>>
>>
>> to:
>>
>>
>> ==============================
>> Test summary
>> ==============================
>> TEST TOTAL PASS FAIL ERROR
>> jtreg:test/jdk/sun/java2d/marlin/ClipShapeTest.java
>> 4 4 0 0
>> ==============================
>> TEST SUCCESS
>>
>> Finished building target 'run-test' in configuration 'macosx-aarch64-server-release'
>>
>> real 1m17.752s
>> user 3m25.308s
>> sys 0m12.987s
>
> test/jdk/sun/java2d/marlin/ClipShapeTest.java line 75:
>
>> 73: * for paths made of either 9 lines, 4 quads, 2 cubics (random)
>> 74: * Note: Use the argument -slow to run more intensive tests (too much time)
>> 75: *
>
> I think our style is only put these in the first `@run` block, and the rest to only carry the essentials for the tests to run. Simplifies the patch as well.
Especially with such a long description that spans four lines.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17719#discussion_r1480207147
More information about the client-libs-dev
mailing list