RFR: 8324539: Do not use LFS64 symbols in JDK libs [v9]

Joachim Kern jkern at openjdk.org
Wed Feb 7 15:56:00 UTC 2024


On Tue, 6 Feb 2024 08:18:14 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK native libraries.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Also fix fstatvfs on AIX

My apologies the additional defines 
`#define DIR DIR64`
`#define dirent dirent64`
`#define opendir opendir64`
`#define readdir readdir64`
`#define closedir closedir64`
are not necessary. Indeed they do not react on _LARGE_FILES, but the DIR struct and the functions are automatically 64 when compiling in 64bit mode (-m64) as we do.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17538#issuecomment-1932343048


More information about the client-libs-dev mailing list