RFR: 8323801: <s> tag doesn't strikethrough the text

[Prasanta Sadhukhan]

On Wed, 31 Jan 2024 17:08:58 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> When `<s>` tag is used inside `<u>`, the `line-through` style is lost, and the text is rendered with `underline` only. However, if `<strike>` is used, the text is rendered with both `underline` and `line-through` styles.
> 
> Both `<s>` and `<strike>` should render the text the same way.

src/java.desktop/share/classes/javax/swing/text/html/HTMLDocument.java line 2504:

> 2502:             tagMap.put(HTML.Tag.SPAN, ca);
> 2503:             tagMap.put(HTML.Tag.STRIKE, conv);
> 2504:             tagMap.put(HTML.Tag.S, conv);

Should we not update the spec
https://github.com/openjdk/jdk/blob/71b46c38a820319851cade2a15d64a657d4d7284/src/java.desktop/share/classes/javax/swing/text/html/HTMLDocument.java#L2314-L2319
to mention that it is now `ConvertAction `and not `CharacterAction`

test/jdk/javax/swing/text/html/HTMLDocument/HTMLStrike.java line 84:

> 82:         if (!errors.isEmpty()) {
> 83:             errors.delete(errors.length() - 2, errors.length());
> 84:             throw new Error(errors + " must have both "

Should it be RuntimeException inline with other tests?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17659#discussion_r1484158996
PR Review Comment: https://git.openjdk.org/jdk/pull/17659#discussion_r1484159910