RFR: 8307246 : Printing: banded raster path doesn't account for device offset values [v11]

Phil Race prr at openjdk.org
Sun Feb 11 19:43:05 UTC 2024


On Fri, 9 Feb 2024 09:36:16 GMT, vtstydev <duke at openjdk.org> wrote:

>> More correct way to take in consideration nonzero PHYSICALOFFSETX, PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows platform under certain conditions real device prints shifted image on paper.
>
> vtstydev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Done requested fixes 3

test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java line 44:

> 42: import javax.swing.JFrame;
> 43: import jtreg.SkippedException;
> 44: 

Sorry about this but the test should FAIL if there is no printer. 
SkippedException is appropriate if there were no way to filter printer tests which REQUIRE a printer to do anything useful but there IS, and it is "@key printer".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17030#discussion_r1485652372


More information about the client-libs-dev mailing list