RFR: 8233177: Test case for bug JDK-8001470 fails if there are missing glyphs [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Mon Feb 12 10:18:14 UTC 2024
> Existing regression test is failing because textfield height is not as per test's expectation..Seems like the indic character being tried to render is not being loaded (probably because of missing glyphs) leading to 0 preferredSpan from [BoxView](https://github.com/openjdk/jdk/blame/5a74c2a67ebcb47e51732f03c4be694bdf920469/src/java.desktop/share/classes/javax/swing/text/BoxView.java#L545-L552) which is superclass for `i18nFieldVIew`, the field view for Indic characters.
> Tried block character in the test which is now being loaded properly leading to correct height..
Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
Check with FOnt.canDisplay
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17528/files
- new: https://git.openjdk.org/jdk/pull/17528/files/a083d6db..a48d451e
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17528&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17528&range=00-01
Stats: 55 lines in 1 file changed: 27 ins; 7 del; 21 mod
Patch: https://git.openjdk.org/jdk/pull/17528.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17528/head:pull/17528
PR: https://git.openjdk.org/jdk/pull/17528
More information about the client-libs-dev
mailing list