RFR: 8323801: <s> tag doesn't strikethrough the text

Alexey Ivanov aivanov at openjdk.org
Mon Feb 12 10:53:04 UTC 2024


On Mon, 12 Feb 2024 07:09:43 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> It's a good question.
>> 
>> We can't do it because `ConvertAction` is not public. In fact, `B`, `FONT`, `I`, `STRIKE`, `SUB`, `SUP`, `U` use `ConvertAction` instead of the specified `CharacterAction`.
>> 
>> The bigger problem is that `ConvertAction` does not extend `CharacterAction`, which means the implementation is different from what is specified. It is the result of [JDK-4171509](https://bugs.openjdk.org/browse/JDK-4171509).
>> 
>> There are a few more inconsistencies between the table and the real implementation. There are also references to non-public action classes, such as `TitleAction`, `LinkAction`…
>
> Probably we can do away with those tags which mention internal class OR mention the public action instead, like TagAction instead of ConvertAction
> HiddenAction instead of TitleAction etc

I agree we should do something about it. I think `ConvertAction` can be subclass of `CharacterAction`, then the listed actions in the table will be more inline with the implementation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17659#discussion_r1486014149


More information about the client-libs-dev mailing list