RFR: 8233177: Test case for bug JDK-8001470 fails if there are missing glyphs [v2]
Alexey Ivanov
aivanov at openjdk.org
Mon Feb 12 20:42:05 UTC 2024
On Tue, 23 Jan 2024 09:34:54 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Check with FOnt.canDisplay
>
> test/jdk/javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java line 71:
>
>> 69: height2 = textField2.getHeight();
>> 70: });
>> 71: if( height1 < 10 || height2 < 10 ) {
>
> Suggestion:
>
> if ( height1 < 10 || height2 < 10 ) {
It should be
if (height1 < 10 || height2 < 10) {
No spaces after the opening parenthesis and before the closing one.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17528#discussion_r1486734329
More information about the client-libs-dev
mailing list