RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v8]

Andrey Turbanov aturbanov at openjdk.org
Wed Feb 14 09:17:03 UTC 2024


On Wed, 14 Feb 2024 09:06:19 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added braces for one-line blocks.

test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line 213:

> 211:             } catch (NumberFormatException nfe) {
> 212:                 JOptionPane.showMessageDialog(null,
> 213:                         "NumberFormatException occured","Error",

Suggestion:

                        "NumberFormatException occured", "Error",

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1489146323


More information about the client-libs-dev mailing list