RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
Phil Race
prr at openjdk.org
Thu Feb 15 02:23:53 UTC 2024
On Thu, 15 Feb 2024 02:10:59 GMT, Phil Race <prr at openjdk.org> wrote:
>>> (arm-waving alert) 99% of apps don't do it at all,
>>
>> That may not be so arm-wavy actually considering this has been a problem for a while and we haven't exactly been inundated with complaints, especially since on RH & (I think) Fedora distros SystemTray isn't supported anyway unless you install gnome-shell-extensions.
>>
>> But hmm .. there's a thought - so long as available returns false anyway (via the existing code) do we even need to make this call ? Might need to be careful about when/whether the selectionListener is added.
>> Alexander can you look at that to see if we can just not bother with the exec if it isn't going to be needed anyway ?
>
> If we do that we could be up to 99.5% of cases aren't affected.
And in fact we need to be VERY careful that we don't turn the existing code reporting "available == false" into "true" due to us simply detecting Gnome >= 45 .. that would be unfortunate.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17860#discussion_r1490289685
More information about the client-libs-dev
mailing list