RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v2]

Abhishek Kumar abhiscxk at openjdk.org
Thu Feb 15 08:40:09 UTC 2024


On Thu, 15 Feb 2024 07:58:46 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   spacing fix
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java line 677:
> 
>> 675:     }
>> 676: 
>> 677:     private Color getUnselectedBackgroundAt(int index) {
> 
> I guess `getUnselectedBackground` would be right naming convention.

Don't think so as there is an `index` argument.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1490616641


More information about the client-libs-dev mailing list