RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Thu Feb 15 16:15:55 UTC 2024
On Thu, 15 Feb 2024 16:05:17 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:
>>> If we have Gnome Shell < 45:
>>> -> SystemTray is not supported(`isSupported` returns `false`)
>>
>> If isSupported returns false for version < 45, then why we need this code because as I understand, if systemTray is unsupported, then system tray is not there, so the need to check for any icon present in tray doesn't arise so there should not be need of calling `shouldDisableSystemTray` , right? I am bit confused..
>
> All current `shouldDisableSystemTray` checks in `XSystemTrayPeer` are aimed at preventing the `available` value from changing and leaving it as `false`, because the `isSupported` is decided based on the `XSystemTrayPeer#isAvailable` response.
> We can replace the `ownerChanged` and `ownerDeath` checks with the check in `isAvailable`, but not this time.
ok..thanks for the explanation..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17860#discussion_r1491263862
More information about the client-libs-dev
mailing list