RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v4]

[Christoph Langer]

On Fri, 16 Feb 2024 11:29:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Little cleanup
>
> src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsDevice.cpp line 200:
> 
>> 198:     }
>> 199: 
>> 200:     if (colorData->bitsperpixel > 8) {
> 
> So at this time, the code below will not be run if an error occurs. This may lead to leaving the fields of `gpBitmapInfo` uninitialised.
> 
> I'm unsure how critical it is… even though we're (presumably) on a headless system.

OK, yes, I'll turn this back to previous behavior. Rather don't touch something at all if we have no idea... 😉

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1492402563