RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v4]
Christoph Langer
clanger at openjdk.org
Fri Feb 16 13:26:19 UTC 2024
- Previous message (by thread): RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v4]
- Next message (by thread): RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v4]
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
On Fri, 16 Feb 2024 12:52:34 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> OK, yes, I'll turn this back to previous behavior. Rather don't touch something at all if we have no idea... 😉
>
> I prefer *backing out*… — it makes the code cleaner. At the same time, I am unsure about the consequences of doing so. I could be safer to run the code below, especially if you take into account that there's a fallback already:
>
> https://github.com/openjdk/jdk/blob/fb90af881badf143163c7d0b9961152c2a12cd84/src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsDevice.cpp#L192-L199
Reverted that stuff.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1492444458
- Previous message (by thread): RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v4]
- Next message (by thread): RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v4]
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the client-libs-dev
mailing list