RFR: 8233177: Remove testcase for JDK-8001470 as fix has been reverted [v3]
Phil Race
prr at openjdk.org
Fri Feb 16 22:48:57 UTC 2024
On Tue, 13 Feb 2024 07:50:15 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Existing regression test is failing because textfield height is not as per test's expectation..Seems like the indic character being tried to render is not being loaded (probably because of missing glyphs) leading to 0 preferredSpan from [BoxView](https://github.com/openjdk/jdk/blame/5a74c2a67ebcb47e51732f03c4be694bdf920469/src/java.desktop/share/classes/javax/swing/text/BoxView.java#L545-L552) which is superclass for `i18nFieldVIew`, the field view for Indic characters.
>> Tried block character in the test which is now being loaded properly leading to correct height..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Test removed as corresponding fix is reverted
This is getting to be a long thread. Mostly about whether to keep this test.
It is unusual to have a test in the repo problem listed for an unfixed bug but I am not sure if that's the most important point here.
" so why should we impose the test on the fixer of JDK-8001470..Let him/her devise a new testcase for the fix he/she proposes "
So do we have an OPEN bug targeting fixing the original problem since 8001470 can not of course be re-used ?
I get the sense it was actually supposed to be this one (8233177).
So if it is resolved as removing the test we'll have no open bug and no test .. both for an as yet unresolved problem.
If this test is removed there needs to be a new bug with this test attached as a test case
to demonstrate the problem. If there's something wrong with this test then some new test case would need to be attached to it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17528#issuecomment-1949440826
More information about the client-libs-dev
mailing list