RFR: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox. [v3]
Abhishek Kumar
abhiscxk at openjdk.org
Thu Feb 22 06:26:57 UTC 2024
On Thu, 22 Feb 2024 05:10:56 GMT, Tejesh R <tr at openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove WindowsLAF check
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java line 1024:
>
>> 1022: "TabbedPane.font", new FontLazyValue(Region.TABBED_PANE),
>> 1023: "TabbedPane.selectedTabPadInsets", new InsetsUIResource(2, 2, 0, 1),
>> 1024: "TabbedPane.selected", tabbedPaneBg,
>
> `TabbedPane.selected` already existed or newly added ? If newly added then it would be better to name it as `SelectedColor` or something similar.
`TabbedPane.selected` is added as a new property. Property name is kept similar to Metal property (MetalTabbedPaneUI.java) to keep consistency.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1498708375
More information about the client-libs-dev
mailing list