RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v6]

Christoph Langer clanger at openjdk.org
Fri Feb 23 21:58:11 UTC 2024


On Fri, 23 Feb 2024 21:43:21 GMT, Phil Race <prr at openjdk.org> wrote:

> The change looks good but I'd like to run it through all our tests since if there's anything wrong with this code path we are in trouble :-)

Yes, please test thoroughly and let me know. I'll give it another spin in our testing as well.

> src/java.desktop/windows/classes/sun/awt/Win32GraphicsEnvironment.java line 91:
> 
>> 89:     private static native void initDisplay();
>> 90: 
>> 91:     private static boolean displayInitialized;      // = false;
> 
> So it seems like this is currently un-needed since there's only the one static initializer that calls this, so removing it should be fine.

Exactly. There is just this one private usage.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17614#issuecomment-1962052846
PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1501212535


More information about the client-libs-dev mailing list