RFR: 8325097: [macos14] DisposeInActionEventTest.html failed with message: "Event posted on wrong app contex" [v8]

Alexey Ivanov aivanov at openjdk.org
Wed Feb 28 14:39:54 UTC 2024


On Tue, 27 Feb 2024 11:00:14 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove system property set
>
> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 60:
> 
>> 58:                        "  (also called Taskbar Status Area on MS Windows, Notification\n" +
>> 59:                        "  Area on Gnome or System Tray on KDE) is visible.\n\n" +
>> 60:                         clickInstruction + " the button on the tray icon to trigger the\n" +
> 
> _“Right-click the button”_ or _“Double-left click the button”_ doesn't make sense to me.

The recent update didn't clarify it, now the text reads _“Right-click the button”_ or _“Double click the button”_.

I assume _“the button”_ refers to the mouse button. But it's very confusing, it's not clear what is required; because “right-click” and “double-click” already define which _mouse button_ to use.

What you want to say is _“Right-click / Double-click on **the tray icon**…”_

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1506056726


More information about the client-libs-dev mailing list