RFR: JDK-8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns

Matthias Baesken mbaesken at openjdk.org
Wed Feb 28 15:32:52 UTC 2024


On Thu, 22 Feb 2024 08:25:13 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> > In other words, this CHECK should be placed next to where I can see the call that requires it.
> 
> Hi Phil, I thought about this too. Just one EXCEPTION_CHECK_WITH_RELEASE macro and there the second check inside this macro, the two EXCEPTION_CHECK_WITH_RELEASE and EXCEPTION_CHECK just after it look a bit odd. 


Adjusted the coding, now do more in the EXCEPTION_CHECK_WITH_RELEASE macro. Please check .

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17915#issuecomment-1969233182


More information about the client-libs-dev mailing list