RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pressed. [v3]

Abhishek Kumar abhiscxk at openjdk.org
Thu Feb 29 17:36:53 UTC 2024


On Thu, 29 Feb 2024 11:02:35 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment update
>
> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsMenuBarUI.java line 152:
> 
>> 150:                 //MenuElement[] path = new MenuElement[2];
>> 151:                 //path[0] = (MenuElement)menuBar;
>> 152:                 //path[1] = (MenuElement)menu;
> 
> Do not leave commented out code. The source control system is used to record the history.
> 
> If you want to keep the old way, you can still do it by replacing one line
> 
> MenuElement[] path = {menuBar, menu};
> 
> inside `else` with these three lines.

Oh! my bad. I pushed it by mistake. Will update in next iteration.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1507946680


More information about the client-libs-dev mailing list