RFR: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails

[Alexandre Iline]

On Thu, 29 Feb 2024 09:34:05 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Test failed with the exception java.lang.IllegalArgumentException: (start <= value <= end) with no history of failing till date.
> Investigation shows SpinnerDateModel constructor condition is not satisfied because
> It seems it's a leap year problem that is being manifested..
> 
> As per test,
> initDate Thu Feb 29 13:49:08 IST 2024 [ obtained by calendar.getTime();]
> earliestDate Tue Feb 28 13:49:08 IST 2023 [obtained by calendar.add(Calendar.YEAR, -1);]
> latestDate Wed Feb 28 13:49:08 IST 2024 [obtained by calendar.add(Calendar.YEAR, 1);]
> 
> Now, as per SpinnerDateModel constructor
> earliestDate <= initDate condition is satisfied
> but
> latestDate >= initDate is not
> so [start <= value <= end](https://github.com/openjdk/jdk/blob/998d0baab0fd051c38d9fd6021628eb863b80554/src/java.desktop/share/classes/javax/swing/SpinnerDateModel.java#L185) condition fails
> 
> Not sure it anything can be done in Calendar class for this but fix is done in test taking leapyear into account so that we add a day if it's a leapyear when we consecutively do Calendar.add(YEAR, -1) and Calendar.add(YEAR,1) on leapyear date of 29Feb

test/jdk/javax/swing/JSpinner/8008657/bug8008657.java line 138:

> 136:         Date initDate = calendar.getTime();
> 137:         int year = calendar.get(Calendar.YEAR);
> 138:         boolean isLeapYear = ((year % 4 == 0) && (year % 100 != 0) || (year % 400 == 0));

Would it be better to use java.tim.Year.isLeap(long)?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18054#discussion_r1508083260