RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v6]

Renjith Kannath Pariyangad rkannathpari at openjdk.org
Wed Jan 3 03:45:06 UTC 2024


On Tue, 2 Jan 2024 05:29:35 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed unnecessary try block
>
> test/jdk/java/awt/color/NonICCFilterTest.java line 47:
> 
>> 45: 
>> 46:         protected TestColorSpace(boolean bSrc) {
>> 47:             super(CS_sRGB, 3);
> 
> CS_sRGB is not a constant of the ColorSpace type, the ICC_Profile.getInstance(xx).getColorSpaceType() and profile.getNumComponents() should be used.

Integrated this, please review

> test/jdk/java/awt/color/NonICCFilterTest.java line 53:
> 
>> 51: 
>> 52:         public float[] toRGB(float[] colorvalue) {
>> 53:             return colorvalue;
> 
> Just for completeness, it is probably better to use csRGB.toRGB and csRGB.fromRGB in these two methods

Updated this

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16895#discussion_r1440043145
PR Review Comment: https://git.openjdk.org/jdk/pull/16895#discussion_r1440043507


More information about the client-libs-dev mailing list