RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v6]

Renjith Kannath Pariyangad rkannathpari at openjdk.org
Thu Jan 4 04:45:22 UTC 2024


On Wed, 3 Jan 2024 21:04:50 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I agree with Sergey and I can't see any updates.
>
> Hm… If modify the `toRGB` and `fromRGB` methods to use `csRGB` object, then the test does not fail without the fix.
> 
> What's more interesting is that the images are equal before `filter` is applied.

@aivanov-jdk Thank you for clarifying, I thought he mean to modify `toCIEXYZ` and `fromCIEXYZ`. Yes if we modify `toRGB `and `fromRGB` then it will not pass through fixed area, So we may need to skip this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16895#discussion_r1441287458


More information about the client-libs-dev mailing list