RFR: 8264102: JTable Keyboards Navigation differs with Test Instructions. [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Jan 8 04:08:24 UTC 2024


On Fri, 5 Jan 2024 07:31:46 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Updated the actions for "ctrl shift DOWN" to "`selectLastRowExtendSelection`" and  "ctrl shift UP", "`selectFirstRowExtendSelection`" in Basic and other Look and feel. Tested in CI and no regressions found. 
>> Test to be used - [javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java](https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java)
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review Fix

test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 194:

> 192: 
> 193:     public static void main(String[] args) throws Exception {
> 194:         UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");

The fix is for all L&F but the test is testing only Metal...It should be given chance to use default L&F in each platform..
If 4112270 is only about Metal, then a new test should be spawned to test this fix for all fixed L&F..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17236#discussion_r1444158927


More information about the client-libs-dev mailing list