RFR: 8264102: JTable Keyboards Navigation differs with Test Instructions. [v4]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Jan 9 07:03:23 UTC 2024


On Mon, 8 Jan 2024 09:47:50 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Updated the actions for "ctrl shift DOWN" to "`selectLastRowExtendSelection`" and  "ctrl shift UP", "`selectFirstRowExtendSelection`" in Basic and other Look and feel. Tested in CI and no regressions found. 
>> Test to be used - [javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java](https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java)
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removing Metal specific L&F from test

Looks ok to me...
Only thing is...If it could be done without much trouble, I would have listed the combinations of keyboard navigation in the test itself instead of directing to 4112270

-------------

Marked as reviewed by psadhukhan (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17236#pullrequestreview-1810511365


More information about the client-libs-dev mailing list