RFR: 8264102: JTable Keyboards Navigation differs with Test Instructions. [v5]

Abhishek Kumar abhiscxk at openjdk.org
Wed Jan 10 05:13:28 UTC 2024


On Tue, 9 Jan 2024 07:57:57 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Updated the actions for "ctrl shift DOWN" to "`selectLastRowExtendSelection`" and  "ctrl shift UP", "`selectFirstRowExtendSelection`" in Basic and other Look and feel. Tested in CI and no regressions found. 
>> Test to be used - [javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java](https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java)
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated test instructions

test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 221:

> 219:         JTable tableView = new JTable(dataModel);
> 220:         // Turn off auto-resizing so that we can set column sizes programmatically.
> 221:         // In this mode, all columns will get their preferred widths, as set blow.

looks like a typo
Suggestion:

        // In this mode, all columns will get their preferred widths, as set below.

test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 230:

> 228:             try {
> 229:                 initTest();
> 230:             } catch (Exception e) {

try-catch block may be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17236#discussion_r1446889141
PR Review Comment: https://git.openjdk.org/jdk/pull/17236#discussion_r1446889773


More information about the client-libs-dev mailing list