RFR: 8258979: The image didn't show correctly with GTK LAF [v4]

Abhishek Kumar abhiscxk at openjdk.org
Wed Jan 10 10:52:44 UTC 2024


> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned from BasicTreeUI class which doesn't contain any icon image whereas the expanded icon is returned from SynthTreeUI class and expanded icon is rendered correctly.
> The proposed fix is to return collapsed icon as an object of collapsed icon wrapper which implements synthIcon and is similar to the expanded icon implementation.
> 
> Test mentioned in JBS is an applet based which is converted to main based now and extended for all installed LAFs on the system.
> 
> No regression caused with the fix, link is attached in JBS .

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  ExpandedIconWrapper and CollapsedIconWrapper class merged together

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17294/files
  - new: https://git.openjdk.org/jdk/pull/17294/files/ed5caa98..2fa05f9f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17294&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17294&range=02-03

  Stats: 76 lines in 1 file changed: 32 ins; 33 del; 11 mod
  Patch: https://git.openjdk.org/jdk/pull/17294.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17294/head:pull/17294

PR: https://git.openjdk.org/jdk/pull/17294


More information about the client-libs-dev mailing list