RFR: 8258979: The image didn't show correctly with GTK LAF [v4]

Abhishek Kumar abhiscxk at openjdk.org
Wed Jan 10 12:23:30 UTC 2024


On Wed, 10 Jan 2024 11:26:17 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   ExpandedIconWrapper and CollapsedIconWrapper class merged together
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTreeUI.java line 82:
> 
>> 80:     private Icon expandedIconWrapper = new IconWrapper(IconType.EXPANDED);
>> 81: 
>> 82:     private Icon collapsedIconWrapper = new IconWrapper(IconType.COLLAPSED);
> 
> I guess you can pass in `collapsedIcon` or `expandedIcon`  to `IconWrapper `class which can save it in `icon` field and
> Then IconWrapper class can just call `SynthGraphicsUtils.paintIcon(icon, context, g, x, y, w, h);`

I tried with this approach first but images didn't render at all.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17294#discussion_r1447313431


More information about the client-libs-dev mailing list