RFR: JDK-8320405: [Windows Server 2016] java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java shows issues in awt_Win32GraphicsDevice.cpp

[Alexey Ivanov]

On Thu, 4 Jan 2024 14:40:59 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> > It should be extended to include the possible failure in the preceding call to ::GetDIBits.
> 
> I handle now also a failure of the first GetDIBits call; and also added braces at the if's mentioned.

Sorry for my delayed reply. It's not what I expected.

What I meant is that we shouldn't even call `::CreateCompatibleBitmap` if `hBMDC == NULL`. Then we shouldn't call `::GetDIBits` if `hBM == NULL`. Thus in this case, the _fallback_ code path should be taken.

Perhaps, the code could be restructured… Yet I don't fully understand what's done here.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17197#issuecomment-1885284337